diff options
| author | Thomas Gleixner <[email protected]> | 2020-09-29 20:25:15 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2020-09-29 21:02:53 +0000 |
| commit | a17409e73bc559e9619d478fab92c8a160b77ff9 (patch) | |
| tree | 7f14648b8f0c480bf71f8603dfeb0ee57c2ad9b9 /drivers/net/ethernet/intel/igc/igc_phy.c | |
| parent | net: atheros: Remove WARN_ON(in_interrupt()) (diff) | |
| download | kernel-a17409e73bc559e9619d478fab92c8a160b77ff9.tar.gz kernel-a17409e73bc559e9619d478fab92c8a160b77ff9.zip | |
net: cxgb3: Cleanup in_interrupt() usage
t3_sge_stop() is called from task context and from error handlers in
interrupt context. It relies on in_interrupt() to differentiate the
contexts.
in_interrupt() is deprecated as it is ill defined and does not provide what
it suggests.
Instead of replacing it with some other construct, simply split the
function into t3_sge_stop_dma(), which can be called from any context, and
t3_sge_stop() which can be only called from task context.
This has the advantage that any bogus invocation of t3_sge_stop() from
wrong contexts can be caught by debug kernels instead of being papered over
by the conditional.
Signed-off-by: Thomas Gleixner <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc_phy.c')
0 files changed, 0 insertions, 0 deletions
