diff options
| author | Rand Deeb <[email protected]> | 2025-03-06 10:12:00 +0000 |
|---|---|---|
| committer | Tony Nguyen <[email protected]> | 2025-04-11 18:58:58 +0000 |
| commit | cdcb3804eeda24d588348bbab6766cf14fddbeaa (patch) | |
| tree | 0e95d1bb86aa199127c070e7198fd3d53864deab /drivers/net/ethernet/intel/igc/igc_main.c | |
| parent | i40e: fix MMIO write access to an invalid page in i40e_clear_hw (diff) | |
| download | kernel-cdcb3804eeda24d588348bbab6766cf14fddbeaa.tar.gz kernel-cdcb3804eeda24d588348bbab6766cf14fddbeaa.zip | |
ixgbe: Fix unreachable retry logic in combined and byte I2C write functions
The current implementation of `ixgbe_write_i2c_combined_generic_int` and
`ixgbe_write_i2c_byte_generic_int` sets `max_retry` to `1`, which makes
the condition `retry < max_retry` always evaluate to `false`. This renders
the retry mechanism ineffective, as the debug message and retry logic are
never executed.
This patch increases `max_retry` to `3` in both functions, aligning them
with the retry logic in `ixgbe_read_i2c_combined_generic_int`. This
ensures that the retry mechanism functions as intended, improving
robustness in case of I2C write failures.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Rand Deeb <[email protected]>
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc_main.c')
0 files changed, 0 insertions, 0 deletions