diff options
| author | Guillaume Nault <[email protected]> | 2019-03-19 15:05:44 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2019-03-19 21:13:01 +0000 |
| commit | 9403cf2302588022d06f1878b072d3f6933021f0 (patch) | |
| tree | d69594772fc7481e9db2f296b0c4ac8fe6d4a591 /drivers/net/ethernet/intel/igc/igc_main.c | |
| parent | datagram: Make __skb_datagram_iter static (diff) | |
| download | kernel-9403cf2302588022d06f1878b072d3f6933021f0.tar.gz kernel-9403cf2302588022d06f1878b072d3f6933021f0.zip | |
tcp: free request sock directly upon TFO or syncookies error
Since the request socket is created locally, it'd make more sense to
use reqsk_free() instead of reqsk_put() in TFO and syncookies' error
path.
However, tcp_get_cookie_sock() may set ->rsk_refcnt before freeing the
socket; tcp_conn_request() may also have non-null ->rsk_refcnt because
of tcp_try_fastopen(). In both cases 'req' hasn't been exposed
to the outside world and is safe to free immediately, but that'd
trigger the WARN_ON_ONCE in reqsk_free().
Define __reqsk_free() for these situations where we know nobody's
referencing the socket, even though ->rsk_refcnt might be non-null.
Now we can consolidate the error path of tcp_get_cookie_sock() and
tcp_conn_request().
Signed-off-by: Guillaume Nault <[email protected]>
Signed-off-by: Eric Dumazet <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc_main.c')
0 files changed, 0 insertions, 0 deletions