aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/igc/igc_main.c
diff options
context:
space:
mode:
authorToke Høiland-Jørgensen <[email protected]>2021-06-24 16:05:57 +0000
committerDaniel Borkmann <[email protected]>2021-06-24 17:43:28 +0000
commit0939e0537896e421e391fa4b1a0b052907808e0d (patch)
tree94ab414ba688756b8a15d053190635bafaef6b30 /drivers/net/ethernet/intel/igc/igc_main.c
parentbpf, sched: Remove unneeded rcu_read_lock() around BPF program invocation (diff)
downloadkernel-0939e0537896e421e391fa4b1a0b052907808e0d.tar.gz
kernel-0939e0537896e421e391fa4b1a0b052907808e0d.zip
ena: Remove rcu_read_lock() around XDP program invocation
The ena driver has rcu_read_lock()/rcu_read_unlock() pairs around XDP program invocations. However, the actual lifetime of the objects referred by the XDP program invocation is longer, all the way through to the call to xdp_do_flush(), making the scope of the rcu_read_lock() too small. This turns out to be harmless because it all happens in a single NAPI poll cycle (and thus under local_bh_disable()), but it makes the rcu_read_lock() misleading. Rather than extend the scope of the rcu_read_lock(), just get rid of it entirely. With the addition of RCU annotations to the XDP_REDIRECT map types that take bh execution into account, lockdep even understands this to be safe, so there's really no reason to keep it around. Signed-off-by: Toke Høiland-Jørgensen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Cc: Saeed Bishara <[email protected]> Cc: Guy Tzalik <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc_main.c')
0 files changed, 0 insertions, 0 deletions