diff options
| author | Tuong Lien <[email protected]> | 2020-06-02 04:46:40 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2020-06-02 22:13:46 +0000 |
| commit | 049fa17f7ae6b0971ad41b761479962facafea4b (patch) | |
| tree | 7fca7334b7c3d61af4558afda17c449768673240 /drivers/net/ethernet/intel/igc/igc_main.c | |
| parent | vmxnet3: allow rx flow hash ops only when rss is enabled (diff) | |
| download | kernel-049fa17f7ae6b0971ad41b761479962facafea4b.tar.gz kernel-049fa17f7ae6b0971ad41b761479962facafea4b.zip | |
Revert "tipc: Fix potential tipc_node refcnt leak in tipc_rcv"
This reverts commit de058420767df21e2b6b0f3bb36d1616fb962032.
There is no actual tipc_node refcnt leak as stated in the above commit.
The refcnt is hold carefully for the case of an asynchronous decryption
(i.e. -EINPROGRESS/-EBUSY and skb = NULL is returned), so that the node
object cannot be freed in the meantime. The counter will be re-balanced
when the operation's callback arrives with the decrypted buffer if any.
In other cases, e.g. a synchronous crypto the counter will be decreased
immediately when it is done.
Now with that commit, a kernel panic will occur when there is no node
found (i.e. n = NULL) in the 'tipc_rcv()' or a premature release of the
node object.
This commit solves the issues by reverting the said commit, but keeping
one valid case that the 'skb_linearize()' is failed.
Acked-by: Jon Maloy <[email protected]>
Signed-off-by: Tuong Lien <[email protected]>
Tested-by: Hoang Le <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc_main.c')
0 files changed, 0 insertions, 0 deletions