diff options
| author | Takashi Iwai <[email protected]> | 2020-02-13 06:03:49 +0000 |
|---|---|---|
| committer | Takashi Iwai <[email protected]> | 2020-02-13 15:30:22 +0000 |
| commit | 0fbb027b44e79700da80e4b8bd1c1914d4796af6 (patch) | |
| tree | 218dfdd93e79af7f7df2007ab99cf7106c6d6a3f /drivers/net/ethernet/intel/ice/ice_lib.c | |
| parent | ALSA: usb-audio: Add clock validity quirk for Denon MC7000/MCX8000 (diff) | |
| download | kernel-0fbb027b44e79700da80e4b8bd1c1914d4796af6.tar.gz kernel-0fbb027b44e79700da80e4b8bd1c1914d4796af6.zip | |
ALSA: pcm: Fix double hw_free calls
The commit 66f2d19f8116 ("ALSA: pcm: Fix memory leak at closing a
stream without hw_free") tried to fix the regression wrt the missing
hw_free call at closing without SNDRV_PCM_IOCTL_HW_FREE ioctl.
However, the code change dropped mistakenly the state check, resulting
in calling hw_free twice when SNDRV_PCM_IOCTL_HW_FRE got called
beforehand. For most drivers, this is almost harmless, but the
drivers like SOF show another regression now.
This patch adds the state condition check before calling do_hw_free()
at releasing the stream for avoiding the double hw_free calls.
Fixes: 66f2d19f8116 ("ALSA: pcm: Fix memory leak at closing a stream without hw_free")
Reported-by: Bard Liao <[email protected]>
Reported-by: Pierre-Louis Bossart <[email protected]>
Tested-by: Pierre-Louis Bossart <[email protected]>
Cc: <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/ice/ice_lib.c')
0 files changed, 0 insertions, 0 deletions