diff options
| author | Dan Carpenter <[email protected]> | 2024-03-21 14:42:12 +0000 |
|---|---|---|
| committer | Tony Nguyen <[email protected]> | 2024-04-03 16:15:18 +0000 |
| commit | 90ca6956d3834db4060f87700e2fcbb699c4e4fd (patch) | |
| tree | bff0a206bdcf36e1d1acfcb8931c9aefb32aa455 /drivers/net/ethernet/intel/ice/ice_ethtool.c | |
| parent | net: bcmgenet: Reset RBUF on first open (diff) | |
| download | kernel-90ca6956d3834db4060f87700e2fcbb699c4e4fd.tar.gz kernel-90ca6956d3834db4060f87700e2fcbb699c4e4fd.zip | |
ice: Fix freeing uninitialized pointers
Automatically cleaned up pointers need to be initialized before exiting
their scope. In this case, they need to be initialized to NULL before
any return statement.
Fixes: 90f821d72e11 ("ice: avoid unnecessary devm_ usage")
Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: Jiri Pirko <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Signed-off-by: Tony Nguyen <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/ice/ice_ethtool.c')
| -rw-r--r-- | drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c index 255a9c8151b4..78b833b3e1d7 100644 --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c @@ -941,11 +941,11 @@ static u64 ice_loopback_test(struct net_device *netdev) struct ice_netdev_priv *np = netdev_priv(netdev); struct ice_vsi *orig_vsi = np->vsi, *test_vsi; struct ice_pf *pf = orig_vsi->back; + u8 *tx_frame __free(kfree) = NULL; u8 broadcast[ETH_ALEN], ret = 0; int num_frames, valid_frames; struct ice_tx_ring *tx_ring; struct ice_rx_ring *rx_ring; - u8 *tx_frame __free(kfree); int i; netdev_info(netdev, "loopback test\n"); |