aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/dsa/dsa_loop.c
diff options
context:
space:
mode:
authorRosen Penev <[email protected]>2024-10-28 04:48:28 +0000
committerJakub Kicinski <[email protected]>2024-11-03 18:36:34 +0000
commitf12b363887c706c40611fba645265527a8415832 (patch)
treeee7507d1cdb621b8dc13f9aec37b96805dfd7012 /drivers/net/dsa/dsa_loop.c
parentMerge branch 'add-noinline_for_tracing-and-apply-it-to-tcp_drop_reason' (diff)
downloadkernel-f12b363887c706c40611fba645265527a8415832.tar.gz
kernel-f12b363887c706c40611fba645265527a8415832.zip
net: dsa: use ethtool string helpers
These are the preferred way to copy ethtool strings. Avoids incrementing pointers all over the place. Signed-off-by: Rosen Penev <[email protected]> (for hellcreek driver) Reviewed-by: Kurt Kanzenbach <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'drivers/net/dsa/dsa_loop.c')
-rw-r--r--drivers/net/dsa/dsa_loop.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
index c70ed67cc188..adbab544c60f 100644
--- a/drivers/net/dsa/dsa_loop.c
+++ b/drivers/net/dsa/dsa_loop.c
@@ -121,8 +121,7 @@ static void dsa_loop_get_strings(struct dsa_switch *ds, int port,
return;
for (i = 0; i < __DSA_LOOP_CNT_MAX; i++)
- memcpy(data + i * ETH_GSTRING_LEN,
- ps->ports[port].mib[i].name, ETH_GSTRING_LEN);
+ ethtool_puts(&data, ps->ports[port].mib[i].name);
}
static void dsa_loop_get_ethtool_stats(struct dsa_switch *ds, int port,