diff options
| author | Johannes Berg <[email protected]> | 2017-06-16 12:29:24 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2017-06-16 15:48:40 +0000 |
| commit | 634fef61076d644b989b86abc2f560d81a089a31 (patch) | |
| tree | 41e0cfc0c640666a75ad07588df34addb18176d0 /drivers/net/dsa/dsa_loop.c | |
| parent | networking: make skb_push & __skb_push return void pointers (diff) | |
| download | kernel-634fef61076d644b989b86abc2f560d81a089a31.tar.gz kernel-634fef61076d644b989b86abc2f560d81a089a31.zip | |
networking: add and use skb_put_u8()
Joe and Bjørn suggested that it'd be nicer to not have the
cast in the fairly common case of doing
*(u8 *)skb_put(skb, 1) = c;
Add skb_put_u8() for this case, and use it across the code,
using the following spatch:
@@
expression SKB, C, S;
typedef u8;
identifier fn = {skb_put};
fresh identifier fn2 = fn ## "_u8";
@@
- *(u8 *)fn(SKB, S) = C;
+ fn2(SKB, C);
Note that due to the "S", the spatch isn't perfect, it should
have checked that S is 1, but there's also places that use a
sizeof expression like sizeof(var) or sizeof(u8) etc. Turns
out that nobody ever did something like
*(u8 *)skb_put(skb, 2) = c;
which would be wrong anyway since the second byte wouldn't be
initialized.
Suggested-by: Joe Perches <[email protected]>
Suggested-by: Bjørn Mork <[email protected]>
Signed-off-by: Johannes Berg <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/dsa/dsa_loop.c')
0 files changed, 0 insertions, 0 deletions
