diff options
| author | Uwe Kleine-König <[email protected]> | 2023-04-11 11:38:16 +0000 |
|---|---|---|
| committer | Miquel Raynal <[email protected]> | 2023-04-11 13:42:24 +0000 |
| commit | ec185b18c22323cb0cde0319fa90b3e467b1ed2d (patch) | |
| tree | 3c06787140fc20d245fc2b49b7bc46484098e64d /drivers/mtd/nand/raw/intel-nand-controller.c | |
| parent | mtd: onenand: omap2: Drop obsolete dependency on COMPILE_TEST (diff) | |
| download | kernel-ec185b18c22323cb0cde0319fa90b3e467b1ed2d.tar.gz kernel-ec185b18c22323cb0cde0319fa90b3e467b1ed2d.zip | |
mtd: nand: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Acked-by: Tudor Ambarus <[email protected]>
Acked-by: Nicolas Ferre <[email protected]> # atmel
Reviewed-by: Paul Cercueil <[email protected]> # ingenic
Reviewed-by: Philippe Mathieu-Daudé <[email protected]> # ingenic
Acked-by: Martin Blumenstingl <[email protected]> # intel
Reviewed-by: Martin Blumenstingl <[email protected]> # meson
Acked-by: Roger Quadros <[email protected]> # omap_elm
Reviewed-by: Geert Uytterhoeven <[email protected]> # renesas
Reviewed-by: Heiko Stuebner <[email protected]> # rockchip
Acked-by: Jernej Skrabec <[email protected]> # sunxi
Acked-by: Thierry Reding <[email protected]> # tegra
Signed-off-by: Uwe Kleine-König <[email protected]>
Signed-off-by: Miquel Raynal <[email protected]>
Link: https://lore.kernel.org/linux-mtd/[email protected]
Diffstat (limited to 'drivers/mtd/nand/raw/intel-nand-controller.c')
| -rw-r--r-- | drivers/mtd/nand/raw/intel-nand-controller.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index 6f4cea81f97c..a9909eb08124 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -706,7 +706,7 @@ err_of_node_put: return ret; } -static int ebu_nand_remove(struct platform_device *pdev) +static void ebu_nand_remove(struct platform_device *pdev) { struct ebu_nand_controller *ebu_host = platform_get_drvdata(pdev); int ret; @@ -717,8 +717,6 @@ static int ebu_nand_remove(struct platform_device *pdev) ebu_nand_disable(&ebu_host->chip); ebu_dma_cleanup(ebu_host); clk_disable_unprepare(ebu_host->clk); - - return 0; } static const struct of_device_id ebu_nand_match[] = { @@ -729,7 +727,7 @@ MODULE_DEVICE_TABLE(of, ebu_nand_match); static struct platform_driver ebu_nand_driver = { .probe = ebu_nand_probe, - .remove = ebu_nand_remove, + .remove_new = ebu_nand_remove, .driver = { .name = "intel-nand-controller", .of_match_table = ebu_nand_match, |