diff options
| author | Hans Zhang <[email protected]> | 2025-01-09 09:45:55 +0000 |
|---|---|---|
| committer | Bjorn Helgaas <[email protected]> | 2025-01-21 15:44:14 +0000 |
| commit | 4644db83642d92f6d7407a7786a72cb65c56c10a (patch) | |
| tree | 73adc62a92de5fb5ad0d09d55acd4bab45c50a31 /drivers/misc/pci_endpoint_test.c | |
| parent | misc: pci_endpoint_test: Add consecutive BAR test (diff) | |
| download | kernel-4644db83642d92f6d7407a7786a72cb65c56c10a.tar.gz kernel-4644db83642d92f6d7407a7786a72cb65c56c10a.zip | |
misc: pci_endpoint_test: Remove redundant 'remainder' test
A BAR size is always a power of two. buf_size = min(SZ_1M, bar_size).
If the BAR size is <= 1MB, there will be one iteration, no remainder.
If the BAR size is > 1MB, there will be more than one iteration, but the
size will always be evenly divisible by 1MB, so no remainder.
Link: https://lore.kernel.org/r/[email protected]
Suggested-by: Niklas Cassel <[email protected]>
Signed-off-by: Hans Zhang <[email protected]>
Signed-off-by: Krzysztof Wilczyński <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
Reviewed-by: Niklas Cassel <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]>
Diffstat (limited to 'drivers/misc/pci_endpoint_test.c')
| -rw-r--r-- | drivers/misc/pci_endpoint_test.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index 5c99da952b7a..be0c7c870e6a 100644 --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -283,7 +283,7 @@ static int pci_endpoint_test_bar_memcmp(struct pci_endpoint_test *test, static bool pci_endpoint_test_bar(struct pci_endpoint_test *test, enum pci_barno barno) { - int j, bar_size, buf_size, iters, remain; + int j, bar_size, buf_size, iters; void *write_buf __free(kfree) = NULL; void *read_buf __free(kfree) = NULL; struct pci_dev *pdev = test->pdev; @@ -316,12 +316,6 @@ static bool pci_endpoint_test_bar(struct pci_endpoint_test *test, write_buf, read_buf, buf_size)) return false; - remain = bar_size % buf_size; - if (remain) - if (pci_endpoint_test_bar_memcmp(test, barno, buf_size * iters, - write_buf, read_buf, remain)) - return false; - return true; } |