diff options
| author | Lee Jones <[email protected]> | 2020-07-01 08:58:39 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2020-07-01 13:05:36 +0000 |
| commit | 2557f27fd4891c3475b764d6ce3c48cc9265d424 (patch) | |
| tree | d877bcbeb813efe255d01171a0c0cdf21a39db62 /drivers/misc/ibmasm/command.c | |
| parent | misc: habanalabs: irq: Repair kerneldoc formatting issues (diff) | |
| download | kernel-2557f27fd4891c3475b764d6ce3c48cc9265d424.tar.gz kernel-2557f27fd4891c3475b764d6ce3c48cc9265d424.zip | |
misc: habanalabs: goya: Omit pointless check ensuring addr is >=0
Seeing as 'addr' is unsigned, it would be impossible for the assigned
value to be anything other than zero or positive.
Squashes the following W=1 warnings:
drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_read32’:
drivers/misc/habanalabs/goya/goya.c:3945:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
3945 | } else if ((addr >= DRAM_PHYS_BASE) &&
| ^~
drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_write32’:
drivers/misc/habanalabs/goya/goya.c:4002:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
4002 | } else if ((addr >= DRAM_PHYS_BASE) &&
| ^~
drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_read64’:
drivers/misc/habanalabs/goya/goya.c:4047:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
4047 | } else if ((addr >= DRAM_PHYS_BASE) &&
| ^~
drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_write64’:
drivers/misc/habanalabs/goya/goya.c:4091:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
4091 | } else if ((addr >= DRAM_PHYS_BASE) &&
| ^~
drivers/misc/habanalabs/pci.c:328: warning: Excess function parameter 'dma_mask' description in 'hl_pci_set_dma_mask'
drivers/misc/habanalabs/goya/goya_coresight.c: In function ‘goya_debug_coresight’:
drivers/misc/habanalabs/goya/goya_coresight.c:643:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable]
643 | u32 val;
| ^~~
Cc: Oded Gabbay <[email protected]>
Cc: Tomer Tayar <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
Reviewed-by: Oded Gabbay <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/misc/ibmasm/command.c')
0 files changed, 0 insertions, 0 deletions
