diff options
| author | Anirudh Rayabharam <[email protected]> | 2021-05-16 19:27:14 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2021-05-21 13:04:05 +0000 |
| commit | 02625c965239b71869326dd0461615f27307ecb3 (patch) | |
| tree | f977e43ab1a1e895b291a78284ddf65d24347a1c /drivers/media/v4l2-core/v4l2-async.c | |
| parent | Merge tag 'soundwire-5.13-fixes' of git://git.kernel.org/pub/scm/linux/kernel... (diff) | |
| download | kernel-02625c965239b71869326dd0461615f27307ecb3.tar.gz kernel-02625c965239b71869326dd0461615f27307ecb3.zip | |
video: hgafb: correctly handle card detect failure during probe
The return value of hga_card_detect() is not properly handled causing
the probe to succeed even though hga_card_detect() failed. Since probe
succeeds, hgafb_open() can be called which will end up operating on an
unmapped hga_vram. This results in an out-of-bounds access as reported
by kernel test robot [1].
To fix this, correctly detect failure of hga_card_detect() by checking
for a non-zero error code.
[1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
Cc: stable <[email protected]>
Reported-by: kernel test robot <[email protected]>
Reviewed-by: Igor Matheus Andrade Torrente <[email protected]>
Signed-off-by: Anirudh Rayabharam <[email protected]>
Signed-off-by: Dan Carpenter <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/media/v4l2-core/v4l2-async.c')
0 files changed, 0 insertions, 0 deletions