diff options
| author | Mauro Carvalho Chehab <[email protected]> | 2021-06-10 09:53:45 +0000 |
|---|---|---|
| committer | Mauro Carvalho Chehab <[email protected]> | 2021-06-17 07:29:41 +0000 |
| commit | 128916984208d8f7ccaed6eda840c603fa112910 (patch) | |
| tree | b93833776e0e0abc02591b067eedafed423a7800 /drivers/media/test-drivers/vimc/vimc-sensor.c | |
| parent | media: dvb-core: frontend: make GET/SET safer (diff) | |
| download | kernel-128916984208d8f7ccaed6eda840c603fa112910.tar.gz kernel-128916984208d8f7ccaed6eda840c603fa112910.zip | |
media: xilinx: simplify get fourcc logic
Right now, there are two calls for xvip_get_format_by_fourcc().
If the first one fails, it is called again in order to pick
the first available format: V4L2_PIX_FMT_YUYV.
This ends by producing a smatch warnings:
drivers/media/platform/xilinx/xilinx-dma.c:555 __xvip_dma_try_format() error: 'info' dereferencing possible ERR_PTR()
drivers/media/platform/xilinx/xilinx-dma.c: drivers/media/platform/xilinx/xilinx-dma.c:664 xvip_dma_init() error: 'dma->fmtinfo' dereferencing possible ERR_PTR()
as it is hard for an static analyzer to ensure that calling
xvip_get_format_by_fourcc(XVIP_DMA_DEF_FORMAT) won't return an
error.
So, better to optimize the logic, ensuring that the function
will never return an error.
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Diffstat (limited to 'drivers/media/test-drivers/vimc/vimc-sensor.c')
0 files changed, 0 insertions, 0 deletions