diff options
| author | Zheng Qixing <[email protected]> | 2025-02-27 07:55:06 +0000 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2025-03-06 15:03:28 +0000 |
| commit | 7e5102dd99f3ad1f981671ad5b4f24ac48c568ad (patch) | |
| tree | db6652b05a3e235d1c0e5e6c7d383c5eb0c4d757 /drivers/md/raid1.c | |
| parent | badblocks: return boolean from badblocks_set() and badblocks_clear() (diff) | |
| download | kernel-7e5102dd99f3ad1f981671ad5b4f24ac48c568ad.tar.gz kernel-7e5102dd99f3ad1f981671ad5b4f24ac48c568ad.zip | |
md: improve return types of badblocks handling functions
rdev_set_badblocks() only indicates success/failure, so convert its return
type from int to boolean for better semantic clarity.
rdev_clear_badblocks() return value is never used by any caller, convert it
to void. This removes unnecessary value returns.
Also update narrow_write_error() in both raid1 and raid10 to use boolean
return type to match rdev_set_badblocks().
Signed-off-by: Zheng Qixing <[email protected]>
Reviewed-by: Yu Kuai <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'drivers/md/raid1.c')
| -rw-r--r-- | drivers/md/raid1.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 9d57a88dbd26..8beb8cccc6af 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -2486,7 +2486,7 @@ static void fix_read_error(struct r1conf *conf, struct r1bio *r1_bio) } } -static int narrow_write_error(struct r1bio *r1_bio, int i) +static bool narrow_write_error(struct r1bio *r1_bio, int i) { struct mddev *mddev = r1_bio->mddev; struct r1conf *conf = mddev->private; @@ -2507,10 +2507,10 @@ static int narrow_write_error(struct r1bio *r1_bio, int i) sector_t sector; int sectors; int sect_to_write = r1_bio->sectors; - int ok = 1; + bool ok = true; if (rdev->badblocks.shift < 0) - return 0; + return false; block_sectors = roundup(1 << rdev->badblocks.shift, bdev_logical_block_size(rdev->bdev) >> 9); |