aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md/dm-raid.c
diff options
context:
space:
mode:
authorNathan Huckleberry <[email protected]>2023-02-02 01:23:48 +0000
committerMike Snitzer <[email protected]>2023-02-02 19:26:09 +0000
commitc25da5b7baf1d243e6612ba2b97e2a2c4a1376f6 (patch)
tree0e6b8982c450d3046619e4c22e26b10b003d0aac /drivers/md/dm-raid.c
parentdm integrity: Remove bi_sector that's only used by commented debug code (diff)
downloadkernel-c25da5b7baf1d243e6612ba2b97e2a2c4a1376f6.tar.gz
kernel-c25da5b7baf1d243e6612ba2b97e2a2c4a1376f6.zip
dm verity: stop using WQ_UNBOUND for verify_wq
Setting WQ_UNBOUND increases scheduler latency on ARM64. This is likely due to the asymmetric architecture of ARM64 processors. I've been unable to reproduce the results that claim WQ_UNBOUND gives a performance boost on x86-64. This flag is causing performance issues for multiple subsystems within Android. Notably, the same slowdown exists for decompression with EROFS. | open-prebuilt-camera | WQ_UNBOUND | ~WQ_UNBOUND | |-----------------------|------------|---------------| | verity wait time (us) | 11746 | 119 (-98%) | | erofs wait time (us) | 357805 | 174205 (-51%) | | sha256 ramdisk random read | WQ_UNBOUND | ~WQ_UNBOUND | |----------------------------|-----------=---|-------------| | arm64 (accelerated) | bw=42.4MiB/s | bw=212MiB/s | | arm64 (generic) | bw=16.5MiB/s | bw=48MiB/s | | x86_64 (generic) | bw=233MiB/s | bw=230MiB/s | Using a alloc_workqueue() @max_active arg of num_online_cpus() only made sense with WQ_UNBOUND. Switch the @max_active arg to 0 (aka default, which is 256 per-cpu). Also, eliminate 'wq_flags' since it really doesn't serve a purpose. Cc: Sami Tolvanen <[email protected]> Cc: Eric Biggers <[email protected]> Signed-off-by: Nathan Huckleberry <[email protected]> Reviewed-by: Mikulas Patocka <[email protected]> Signed-off-by: Mike Snitzer <[email protected]>
Diffstat (limited to 'drivers/md/dm-raid.c')
0 files changed, 0 insertions, 0 deletions