diff options
| author | Heiko Stuebner <[email protected]> | 2025-06-10 21:27:48 +0000 |
|---|---|---|
| committer | Heiko Stuebner <[email protected]> | 2025-07-08 15:35:49 +0000 |
| commit | f9f68bf1d0efeadb6c427c9dbb30f307a7def19b (patch) | |
| tree | c53cb2768e12362944ffe608b4aaa304796f6ab8 /drivers/gpu/drm/rockchip/cdn-dp-core.c | |
| parent | drm/rockchip: lvds: Convert to drm bridge (diff) | |
| download | kernel-f9f68bf1d0efeadb6c427c9dbb30f307a7def19b.tar.gz kernel-f9f68bf1d0efeadb6c427c9dbb30f307a7def19b.zip | |
drm/rockchip: vop2: fail cleanly if missing a primary plane for a video-port
Each window of a vop2 is usable by a specific set of video ports, so while
binding the vop2, we look through the list of available windows trying to
find one designated as primary-plane and usable by that specific port.
The code later wants to use drm_crtc_init_with_planes with that found
primary plane, but nothing has checked so far if a primary plane was
actually found.
For whatever reason, the rk3576 vp2 does not have a usable primary window
(if vp0 is also in use) which brought the issue to light and ended in a
null-pointer dereference further down.
As we expect a primary-plane to exist for a video-port, add a check at
the end of the window-iteration and fail probing if none was found.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Reviewed-by: Andy Yan <[email protected]>
Signed-off-by: Heiko Stuebner <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'drivers/gpu/drm/rockchip/cdn-dp-core.c')
0 files changed, 0 insertions, 0 deletions
