aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/omapdrm/omap_fbdev.c
diff options
context:
space:
mode:
authorLukas Wunner <[email protected]>2016-03-09 11:52:53 +0000
committerDaniel Vetter <[email protected]>2016-03-30 06:23:41 +0000
commita7442b93cf32c1e1ddb721a26cd1f92302e2a222 (patch)
treeed0e8f9b8cf0a4b151dacbf94c1e9f608e8ca3f5 /drivers/gpu/drm/omapdrm/omap_fbdev.c
parentdrm/i915: remove unused dev_priv->render_reclock_avail (diff)
downloadkernel-a7442b93cf32c1e1ddb721a26cd1f92302e2a222.tar.gz
kernel-a7442b93cf32c1e1ddb721a26cd1f92302e2a222.zip
drm/i915: Fix races on fbdev
The ->lastclose callback invokes intel_fbdev_restore_mode() and has been witnessed to run before intel_fbdev_initial_config_async() has finished. We might likewise receive hotplug events before we've had a chance to fully set up the fbdev. Fix by waiting for the asynchronous thread to finish. v2: An async_synchronize_full() was also added to intel_fbdev_set_suspend() in v1 which turned out to be entirely gratuitous. It caused a deadlock on suspend (discovered by CI, thanks to Damien Lespiau and Tomi Sarvela for CI support) and was unnecessary since a device is never suspended until its ->probe callback (and all asynchronous tasks it scheduled) have finished. See dpm_prepare(), which calls wait_for_device_probe(), which calls async_synchronize_full(). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93580 Reported-by: Gustav Fägerlind <[email protected]> Reported-by: "Li, Weinan Z" <[email protected]> Cc: Chris Wilson <[email protected]> Cc: [email protected] Signed-off-by: Lukas Wunner <[email protected]> Signed-off-by: Daniel Vetter <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/omapdrm/omap_fbdev.c')
0 files changed, 0 insertions, 0 deletions