diff options
| author | Lyude Paul <[email protected]> | 2024-03-15 21:20:56 +0000 |
|---|---|---|
| committer | Lyude Paul <[email protected]> | 2024-03-15 22:50:17 +0000 |
| commit | 97252d0a4bfbb07079503d059f7522d305fe0f7a (patch) | |
| tree | cedcfe1debe651049bdef22de2633dbe6e8f8dae /drivers/gpu/drm/omapdrm/omap_fbdev.c | |
| parent | drm/panel-edp: Fix AUO 0x405c panel naming and add a variant (diff) | |
| download | kernel-97252d0a4bfbb07079503d059f7522d305fe0f7a.tar.gz kernel-97252d0a4bfbb07079503d059f7522d305fe0f7a.zip | |
drm/nouveau/dp: Fix incorrect return code in r535_dp_aux_xfer()
I've recently been seeing some unexplained GSP errors on my RTX 6000 from
failed aux transactions:
[ 132.915867] nouveau 0000:1f:00.0: gsp: cli:0xc1d00002 obj:0x00730000
ctrl cmd:0x00731341 failed: 0x0000ffff
While the cause of these is not yet clear, these messages made me notice
that the aux transactions causing these transactions were succeeding - not
failing. As it turns out, this is because we're currently not returning the
correct variable when r535_dp_aux_xfer() hits an error - causing us to
never propagate GSP errors for failed aux transactions to userspace.
So, let's fix that.
Fixes: 4ae3a20102b2 ("nouveau/gsp: don't free ctrl messages on errors")
Signed-off-by: Lyude Paul <[email protected]>
Reviewed-by: Dave Airlie <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/omapdrm/omap_fbdev.c')
0 files changed, 0 insertions, 0 deletions