diff options
| author | Thomas Zimmermann <[email protected]> | 2024-11-05 13:38:16 +0000 |
|---|---|---|
| committer | Heiko Stuebner <[email protected]> | 2024-11-09 22:30:24 +0000 |
| commit | 666e1960464140cc4bc9203c203097e70b54c95a (patch) | |
| tree | a6f4c55836f9abcc56c6c2d80d407effe4d644af /drivers/gpu/drm/omapdrm/omap_fbdev.c | |
| parent | drm/sched: Improve teardown documentation (diff) | |
| download | kernel-666e1960464140cc4bc9203c203097e70b54c95a.tar.gz kernel-666e1960464140cc4bc9203c203097e70b54c95a.zip | |
drm/rockchip: cdn-dp: Use drm_connector_helper_hpd_irq_event()
The code for detecting and updating the connector status in
cdn_dp_pd_event_work() has a number of problems.
- It does not aquire the locks to call the detect helper and update
the connector status. These are struct drm_mode_config.connection_mutex
and struct drm_mode_config.mutex.
- It does not use drm_helper_probe_detect(), which helps with the
details of locking and detection.
- It uses the connector's status field to determine a change to
the connector status. The epoch_counter field is the correct one. The
field signals a change even if the connector status' value did not
change.
Replace the code with a call to drm_connector_helper_hpd_irq_event(),
which fixes all these problems.
Signed-off-by: Thomas Zimmermann <[email protected]>
Fixes: 81632df69772 ("drm/rockchip: cdn-dp: do not use drm_helper_hpd_irq_event")
Cc: Chris Zhong <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Sandy Huang <[email protected]>
Cc: "Heiko Stübner" <[email protected]>
Cc: Andy Yan <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: <[email protected]> # v4.11+
Signed-off-by: Heiko Stuebner <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/omapdrm/omap_fbdev.c')
0 files changed, 0 insertions, 0 deletions
