diff options
| author | Wen Yang <[email protected]> | 2019-04-03 16:04:11 +0000 |
|---|---|---|
| committer | Rob Clark <[email protected]> | 2019-04-18 17:04:10 +0000 |
| commit | 6cd5235c3135ea84b32469ea51b2aae384eda8af (patch) | |
| tree | 5c073f5f4943a53f1ed4519f58fba3e7607ed87a /drivers/gpu/drm/msm/msm_submitqueue.c | |
| parent | drm/msm: Cleanup A6XX opp-level reading (diff) | |
| download | kernel-6cd5235c3135ea84b32469ea51b2aae384eda8af.tar.gz kernel-6cd5235c3135ea84b32469ea51b2aae384eda8af.zip | |
drm/msm: a5xx: fix possible object reference leak
The call to of_get_child_by_name returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.
Detected by coccinelle with the following warnings:
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:57:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 47, but without a corresponding object release within this function.
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:66:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 47, but without a corresponding object release within this function.
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:118:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 47, but without a corresponding object release within this function.
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:57:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 51, but without a corresponding object release within this function.
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:66:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 51, but without a corresponding object release within this function.
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:118:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 51, but without a corresponding object release within this function.
Signed-off-by: Wen Yang <[email protected]>
Cc: Rob Clark <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Jordan Crouse <[email protected]>
Cc: Mamta Shukla <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
Cc: Sharat Masetty <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected] (open list)
Reviewed-by: Jordan Crouse <[email protected]>
Signed-off-by: Rob Clark <[email protected]>
Signed-off-by: Rob Clark <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/msm/msm_submitqueue.c')
0 files changed, 0 insertions, 0 deletions