diff options
| author | Casey Chen <[email protected]> | 2021-07-07 21:14:32 +0000 |
|---|---|---|
| committer | Christoph Hellwig <[email protected]> | 2021-07-13 10:03:20 +0000 |
| commit | 251ef6f71be2adfd09546a26643426fe62585173 (patch) | |
| tree | 02dea016d91f5d2045cc2886c40743976cdbdf7a /drivers/gpu/drm/lima/lima_sched.c | |
| parent | nvme-pci: fix multiple races in nvme_setup_io_queues (diff) | |
| download | kernel-251ef6f71be2adfd09546a26643426fe62585173.tar.gz kernel-251ef6f71be2adfd09546a26643426fe62585173.zip | |
nvme-pci: do not call nvme_dev_remove_admin from nvme_remove
nvme_dev_remove_admin could free dev->admin_q and the admin_tagset
while they are being accessed by nvme_dev_disable(), which can be called
by nvme_reset_work via nvme_remove_dead_ctrl.
Commit cb4bfda62afa ("nvme-pci: fix hot removal during error handling")
intended to avoid requests being stuck on a removed controller by killing
the admin queue. But the later fix c8e9e9b7646e ("nvme-pci: unquiesce
admin queue on shutdown"), together with nvme_dev_disable(dev, true)
right before nvme_dev_remove_admin() could help dispatch requests and
fail them early, so we don't need nvme_dev_remove_admin() any more.
Fixes: cb4bfda62afa ("nvme-pci: fix hot removal during error handling")
Signed-off-by: Casey Chen <[email protected]>
Reviewed-by: Keith Busch <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/lima/lima_sched.c')
0 files changed, 0 insertions, 0 deletions