aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/lima/lima_gem.c
diff options
context:
space:
mode:
authorMarek Szyprowski <[email protected]>2020-04-28 11:10:45 +0000
committerMarek Szyprowski <[email protected]>2020-09-10 06:18:35 +0000
commit5e0ff16b9edf3379e5a0e1545b0d9831a7353cca (patch)
tree3e40c0cd83732a1049ad29f9f4a8d2071d813b9f /drivers/gpu/drm/lima/lima_gem.c
parentdrm: vmwgfx: fix common struct sg_table related issues (diff)
downloadkernel-5e0ff16b9edf3379e5a0e1545b0d9831a7353cca.tar.gz
kernel-5e0ff16b9edf3379e5a0e1545b0d9831a7353cca.zip
drm: xen: fix common struct sg_table related issues
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the dma_map_sg(). struct sg_table is a common structure used for describing a non-contiguous memory buffer, used commonly in the DRM and graphics subsystems. It consists of a scatterlist with memory pages and DMA addresses (sgl entry), as well as the number of scatterlist entries: CPU pages (orig_nents entry) and DMA mapped pages (nents entry). It turned out that it was a common mistake to misuse nents and orig_nents entries, calling DMA-mapping functions with a wrong number of entries or ignoring the number of mapped entries returned by the dma_map_sg() function. Fix the code to refer to proper nents or orig_nents entries. This driver reports the number of the pages in the imported scatterlist, so it should refer to sg_table->orig_nents entry. Signed-off-by: Marek Szyprowski <[email protected]> Acked-by: Oleksandr Andrushchenko <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/lima/lima_gem.c')
0 files changed, 0 insertions, 0 deletions