diff options
| author | Carlos Llamas <[email protected]> | 2025-08-25 15:57:42 +0000 |
|---|---|---|
| committer | Rodrigo Vivi <[email protected]> | 2025-08-26 14:12:11 +0000 |
| commit | 75671d90fde8c78e940e15a1366a50ece56c6b69 (patch) | |
| tree | 0f4167d38d72cd20289878118b165ca2d4a28ec5 /drivers/gpu/drm/amd/display/modules/freesync/freesync.c | |
| parent | drm/xe: Don't trigger rebind on initial dma-buf validation (diff) | |
| download | kernel-75671d90fde8c78e940e15a1366a50ece56c6b69.tar.gz kernel-75671d90fde8c78e940e15a1366a50ece56c6b69.zip | |
drm/xe: switch to local xbasename() helper
Commit b0a2ee5567ab ("drm/xe: prepare xe_gen_wa_oob to be multi-use")
introduced a call to basename(). The GNU version of this function is not
portable and fails to build with alternative libc implementations like
musl or bionic. This causes the following build error:
drivers/gpu/drm/xe/xe_gen_wa_oob.c:130:12: error: assignment to ‘const char *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
130 | fn = basename(fn);
| ^
While a POSIX version of basename() could be used, it would require a
separate header plus the behavior differs from GNU version in that it
might modify its argument. Not great.
Instead, implement a local xbasename() helper based on strrchr() that
provides the same functionality and avoids portability issues.
Fixes: b0a2ee5567ab ("drm/xe: prepare xe_gen_wa_oob to be multi-use")
Suggested-by: Lucas De Marchi <[email protected]>
Reviewed-by: Tiffany Yang <[email protected]>
Signed-off-by: Carlos Llamas <[email protected]>
Reviewed-by: Lucas De Marchi <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Lucas De Marchi <[email protected]>
(cherry picked from commit 41be792f5baaf90d744a9a9e82994ce560ca9582)
Signed-off-by: Rodrigo Vivi <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/display/modules/freesync/freesync.c')
0 files changed, 0 insertions, 0 deletions
