diff options
| author | Mario Limonciello <[email protected]> | 2023-09-25 18:48:05 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2023-09-28 19:36:41 +0000 |
| commit | 161d076c2d163d4e6d83e55a6363eb6070eb36b9 (patch) | |
| tree | 49b1419e65f58f063b8f8871293b17a2c088d56f /drivers/gpu/drm/amd/amdgpu/cik_sdma.c | |
| parent | drm/amd/pm: fix the print_clk_levels issue for SMU v13.0.6 (diff) | |
| download | kernel-161d076c2d163d4e6d83e55a6363eb6070eb36b9.tar.gz kernel-161d076c2d163d4e6d83e55a6363eb6070eb36b9.zip | |
drm/amd: Drop error message about failing to load SDMA firmware
The error path for SDMA firmware loading is unnecessarily noisy.
When a firmware is missing 3 errors show up:
```
amdgpu 0000:07:00.0: Direct firmware load for amdgpu/green_sardine_sdma.bin failed with error -2
[drm:sdma_v4_0_early_init [amdgpu]] *ERROR* Failed to load sdma firmware!
[drm:amdgpu_device_init [amdgpu]] *ERROR* early_init of IP block <sdma_v4_0> failed -19
```
The error code for the device init is bubbled up already, remove the
second one.
Signed-off-by: Mario Limonciello <[email protected]>
Reviewed-by: Alex Deucher <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/cik_sdma.c')
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c index 52598fbc9b39..4193289ae82f 100644 --- a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c +++ b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c @@ -943,10 +943,8 @@ static int cik_sdma_sw_init(void *handle) int r, i; r = cik_sdma_init_microcode(adev); - if (r) { - DRM_ERROR("Failed to load sdma firmware!\n"); + if (r) return r; - } /* SDMA trap event */ r = amdgpu_irq_add_id(adev, AMDGPU_IRQ_CLIENTID_LEGACY, 224, |
