diff options
| author | Igor Pylypiv <[email protected]> | 2025-08-14 02:22:56 +0000 |
|---|---|---|
| committer | Damien Le Moal <[email protected]> | 2025-08-14 09:58:12 +0000 |
| commit | 58768b0563916ddcb73d8ed26ede664915f8df31 (patch) | |
| tree | c9be4455014bc6b19a0d94cd9afd58e07b589664 /drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | |
| parent | ata: libata-eh: Fix link state check for IDE/PATA ports (diff) | |
| download | kernel-58768b0563916ddcb73d8ed26ede664915f8df31.tar.gz kernel-58768b0563916ddcb73d8ed26ede664915f8df31.zip | |
ata: libata-scsi: Fix CDL control
Delete extra checks for the ATA_DFLAG_CDL_ENABLED flag that prevent
SET FEATURES command from being issued to a drive when NCQ commands
are active.
ata_mselect_control_ata_feature() sets / clears the ATA_DFLAG_CDL_ENABLED
flag during the translation of MODE SELECT to SET FEATURES. If SET FEATURES
gets deferred due to outstanding NCQ commands, the original MODE SELECT
command will be re-queued. When the re-queued MODE SELECT goes through
the ata_mselect_control_ata_feature() translation again, SET FEATURES
will not be issued because ATA_DFLAG_CDL_ENABLED has been already set or
cleared by the initial translation of MODE SELECT.
The ATA_DFLAG_CDL_ENABLED checks in ata_mselect_control_ata_feature()
are safe to remove because scsi_cdl_enable() implements a similar logic
that avoids enabling CDL if it has been enabled already.
Fixes: 17e897a45675 ("ata: libata-scsi: Improve CDL control")
Cc: [email protected]
Signed-off-by: Igor Pylypiv <[email protected]>
Reviewed-by: Niklas Cassel <[email protected]>
Signed-off-by: Damien Le Moal <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c')
0 files changed, 0 insertions, 0 deletions