diff options
| author | Andy Yan <[email protected]> | 2023-12-17 08:44:15 +0000 |
|---|---|---|
| committer | Heiko Stuebner <[email protected]> | 2023-12-24 23:46:52 +0000 |
| commit | 3ee348eb36f14e9303a7e9757efb91b0bbf3f7a9 (patch) | |
| tree | 4d5575cdf4c3de12989b3ddf29aa77bfd628a68d /drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | |
| parent | drm: Warn when freeing a framebuffer that's still on a list (diff) | |
| download | kernel-3ee348eb36f14e9303a7e9757efb91b0bbf3f7a9.tar.gz kernel-3ee348eb36f14e9303a7e9757efb91b0bbf3f7a9.zip | |
drm/rockchip: vop2: Avoid use regmap_reinit_cache at runtime
Marek Report a possible irq lock inversion dependency warning when
commit 81a06f1d02e5 ("Revert "drm/rockchip: vop2: Use regcache_sync()
to fix suspend/resume"") lands linux-next.
I can reproduce this warning with:
CONFIG_PROVE_LOCKING=y
CONFIG_DEBUG_LOCKDEP=y
It seems than when use regmap_reinit_cache at runtime whith Mark's
commit 3d59c22bbb8d ("drm/rockchip: vop2: Convert to use maple tree
register cache"), it will trigger a possible irq lock inversion dependency
warning.
One solution is switch back to REGCACHE_RBTREE, but it seems that
REGCACHE_MAPLE is the future, so I avoid using regmap_reinit_cache,
and drop all the regcache when vop is disabled, then we get a fresh
start at next enbable time.
Fixes: 81a06f1d02e5 ("Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume"")
Reported-by: Marek Szyprowski <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Andy Yan <[email protected]>
Tested-by: Marek Szyprowski <[email protected]>
[dropped the large kernel log of the lockdep report from the message]
Signed-off-by: Heiko Stuebner <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c')
0 files changed, 0 insertions, 0 deletions
