diff options
| author | Frederic Weisbecker <[email protected]> | 2019-11-08 16:08:56 +0000 |
|---|---|---|
| committer | Ingo Molnar <[email protected]> | 2019-11-11 08:03:31 +0000 |
| commit | 25269871db1ad0cbbaafd5098cbdb40c8db4ccb9 (patch) | |
| tree | 4c8022165bdc48b42d3c62991640a84b3a4ff8f4 /drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | |
| parent | irq_work: Convert flags to atomic_t (diff) | |
| download | kernel-25269871db1ad0cbbaafd5098cbdb40c8db4ccb9.tar.gz kernel-25269871db1ad0cbbaafd5098cbdb40c8db4ccb9.zip | |
irq_work: Fix irq_work_claim() memory ordering
When irq_work_claim() finds IRQ_WORK_PENDING flag already set, we just
return and don't raise a new IPI. We expect the destination to see
and handle our latest updades thanks to the pairing atomic_xchg()
in irq_work_run_list().
But cmpxchg() doesn't guarantee a full memory barrier upon failure. So
it's possible that the destination misses our latest updates.
So use atomic_fetch_or() instead that is unconditionally fully ordered
and also performs exactly what we want here and simplify the code.
Signed-off-by: Frederic Weisbecker <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Paul E . McKenney <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c')
0 files changed, 0 insertions, 0 deletions
