diff options
| author | Heiko Stuebner <[email protected]> | 2025-05-27 22:51:19 +0000 |
|---|---|---|
| committer | Dmitry Baryshkov <[email protected]> | 2025-05-28 13:53:31 +0000 |
| commit | fd03f82a026cc03cb8051a8c6487c99f96c9029f (patch) | |
| tree | e8f2c48cea900d965823f07309aa9804c4eeb12a /drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | |
| parent | drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepar... (diff) | |
| download | kernel-fd03f82a026cc03cb8051a8c6487c99f96c9029f.tar.gz kernel-fd03f82a026cc03cb8051a8c6487c99f96c9029f.zip | |
drm/bridge: analogix_dp: Fix clk-disable removal
Commit 6579a03e68ff ("drm/bridge: analogix_dp: Remove the unnecessary
calls to clk_disable_unprepare() during probing") removed the mismatched
clock_disable calls from analogix_dp_probe.
But that patch was created and sent before
commit e5e9fa9f7aad ("drm/bridge: analogix_dp: Add support to get panel
from the DP AUX bus") was merged, so couldn't know about this change.
So in the original patch the last change is
if (ret) {
dev_err(&pdev->dev, "failed to request irq\n");
- goto err_disable_clk;
+ return ERR_PTR(ret);
}
disable_irq(dp->irq);
return dp;
-
-err_disable_clk:
- clk_disable_unprepare(dp->clock);
- return ERR_PTR(ret);
}
EXPORT_SYMBOL_GPL(analogix_dp_probe);
the analogix_dp_core.c actually now has the runtime-pm handling between
disable_irq() and return do introducing another goto err_clk_disable there.
So remove that one too and return an error pointer, to not create build
breakage.
Fixes: 6579a03e68ff ("drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing")
Signed-off-by: Heiko Stuebner <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Dmitry Baryshkov <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c')
0 files changed, 0 insertions, 0 deletions
