diff options
| author | Pierre-Louis Bossart <[email protected]> | 2021-08-17 16:40:54 +0000 |
|---|---|---|
| committer | Mark Brown <[email protected]> | 2021-08-26 16:42:08 +0000 |
| commit | 6479f7588651cbc9c91e61c20ff39119cbc8feba (patch) | |
| tree | 9b3e7724b27293e80d2f13a81fdd0f18308779e9 /drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | |
| parent | ASoC: soc-pcm: protect BE dailink state changes in trigger (diff) | |
| download | kernel-6479f7588651cbc9c91e61c20ff39119cbc8feba.tar.gz kernel-6479f7588651cbc9c91e61c20ff39119cbc8feba.zip | |
ASoC: soc-pcm: test refcount before triggering
On start/pause_release/resume, when more than one FE is connected to
the same BE, it's possible that the trigger is sent more than
once. This is not desirable, we only want to trigger a BE once, which
is straightforward to implement with a refcount.
For stop/pause/suspend, the problem is more complicated: the check
implemented in snd_soc_dpcm_can_be_free_stop() may fail due to a
conceptual deadlock when we trigger the BE before the FE. In this
case, the FE states have not yet changed, so there are corner cases
where the TRIGGER_STOP is never sent - the dual case of start where
multiple triggers might be sent.
This patch suggests an unconditional trigger in all cases, without
checking the FE states, using a refcount protected by a spinlock.
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c')
0 files changed, 0 insertions, 0 deletions