diff options
| author | Mario Limonciello (AMD) <[email protected]> | 2025-09-05 15:36:27 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2025-09-09 16:26:28 +0000 |
| commit | 60f71f0db7b12f303789ef59949e38ee5838ee8b (patch) | |
| tree | 166129df9fd816a7eef7640c05a648fc9747ab51 /drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | |
| parent | drm/amd/display: Correct sequences and delays for DCN35 PG & RCG (diff) | |
| download | kernel-60f71f0db7b12f303789ef59949e38ee5838ee8b.tar.gz kernel-60f71f0db7b12f303789ef59949e38ee5838ee8b.zip | |
drm/amd/display: Drop dm_prepare_suspend() and dm_complete()
[Why]
dm_prepare_suspend() was added in commit 50e0bae34fa6b
("drm/amd/display: Add and use new dm_prepare_suspend() callback")
to allow display to turn off earlier in the suspend sequence.
This caused a regression that HDMI audio sometimes didn't work
properly after resume unless audio was playing during suspend.
[How]
Drop dm_prepare_suspend() callback. All code in it will still run
during dm_suspend(). Also drop unnecessary dm_complete() callback.
dm_complete() was used for failed prepare and also for any case
of successful resume. The code in it already runs in dm_resume().
This change will introduce more time that the display is turned on
during suspend sequence. The compositor can turn it off sooner if
desired.
Cc: Harry Wentland <[email protected]>
Reported-by: Przemysław Kopa <[email protected]>
Closes: https://lore.kernel.org/amd-gfx/[email protected]/T/#m383d9c08397043a271b36c32b64bb80e524e4b0f
Reported-by: Kalvin <[email protected]>
Closes: https://github.com/alsa-project/alsa-lib/issues/465
Closes: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/4809
Fixes: 50e0bae34fa6b ("drm/amd/display: Add and use new dm_prepare_suspend() callback")
Signed-off-by: Mario Limonciello <[email protected]>
Acked-by: Alex Deucher <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
(cherry picked from commit 2fd653b9bb5aacec5d4c421ab290905898fe85a2)
Cc: [email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c')
0 files changed, 0 insertions, 0 deletions
