diff options
| author | Parav Pandit <[email protected]> | 2020-07-22 15:57:11 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2020-07-23 01:06:08 +0000 |
| commit | 637989b5d77e954007aecaf6cadc7badc6ab94fb (patch) | |
| tree | 2448cd8b05ab02b0bb380e66a819b77e76f72c2e /drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | |
| parent | hv_netvsc: add support for vlans in AF_PACKET mode (diff) | |
| download | kernel-637989b5d77e954007aecaf6cadc7badc6ab94fb.tar.gz kernel-637989b5d77e954007aecaf6cadc7badc6ab94fb.zip | |
devlink: Always use user_ptr[0] for devlink and simplify post_doit
Currently devlink instance is searched on all doit() operations.
But it is optionally stored into user_ptr[0]. This requires
rediscovering devlink again doing post_doit().
Few devlink commands related to port shared buffers needs 3 pointers
(devlink, devlink_port, and devlink_sb) while executing doit commands.
Though devlink pointer can be derived from the devlink_port during
post_doit() operation when doit() callback has acquired devlink
instance lock, relying on such scheme to access devlik pointer makes
code very fragile.
Hence, to avoid ambiguity in post_doit() and to avoid searching
devlink instance again, simplify code by always storing devlink
instance in user_ptr[0] and derive devlink_sb pointer in their
respective callback routines.
Signed-off-by: Parav Pandit <[email protected]>
Reviewed-by: Jiri Pirko <[email protected]>
Acked-by: Jakub Kicinski <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c')
0 files changed, 0 insertions, 0 deletions