diff options
| author | Dmitry Osipenko <[email protected]> | 2023-03-06 16:39:16 +0000 |
|---|---|---|
| committer | Dmitry Osipenko <[email protected]> | 2023-03-06 17:32:17 +0000 |
| commit | aad9729ec0e009440ac8c1a4be2204e4d3c08977 (patch) | |
| tree | f4f82bbd6e2ac1a5cf4f14b1570978c3d0e2a6e1 /drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | |
| parent | drm/meson/meson_venc: Relax the supported mode checks (diff) | |
| download | kernel-aad9729ec0e009440ac8c1a4be2204e4d3c08977.tar.gz kernel-aad9729ec0e009440ac8c1a4be2204e4d3c08977.zip | |
drm/virtio: Fix handling CONFIG_DRM_VIRTIO_GPU_KMS option
VirtIO-GPU got a new config option for disabling KMS. There were two
problems left unnoticed during review when the new option was added:
1. The IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS) check in the code was
inverted, hence KMS was disabled when it should be enabled and vice versa.
2. The disabled KMS crashed kernel with a NULL dereference in
drm_kms_helper_hotplug_event(), which shall not be invoked with a
disabled KMS.
Fix the inverted config option check in the code and skip handling the
VIRTIO_GPU_EVENT_DISPLAY sent by host when KMS is disabled in guest to fix
the crash.
Acked-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Emil Velikov <[email protected]>
Fixes: 72122c69d717 ("drm/virtio: Add option to disable KMS support")
Signed-off-by: Dmitry Osipenko <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_object.h')
0 files changed, 0 insertions, 0 deletions