diff options
| author | Eric Dumazet <[email protected]> | 2019-10-08 17:32:04 +0000 |
|---|---|---|
| committer | Thomas Gleixner <[email protected]> | 2019-10-14 13:51:49 +0000 |
| commit | ff229eee3d897f52bd001c841f2d3cce8853ecdc (patch) | |
| tree | ff2aeaf672e1e411d2054ca722f7d0e84eec72f6 /drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | |
| parent | Linux 5.4-rc3 (diff) | |
| download | kernel-ff229eee3d897f52bd001c841f2d3cce8853ecdc.tar.gz kernel-ff229eee3d897f52bd001c841f2d3cce8853ecdc.zip | |
hrtimer: Annotate lockless access to timer->base
Followup to commit dd2261ed45aa ("hrtimer: Protect lockless access
to timer->base")
lock_hrtimer_base() fetches timer->base without lock exclusion.
Compiler is allowed to read timer->base twice (even if considered dumb)
which could end up trying to lock migration_base and return
&migration_base.
base = timer->base;
if (likely(base != &migration_base)) {
/* compiler reads timer->base again, and now (base == &migration_base)
raw_spin_lock_irqsave(&base->cpu_base->lock, *flags);
if (likely(base == timer->base))
return base; /* == &migration_base ! */
Similarly the write sides must use WRITE_ONCE() to avoid store tearing.
Signed-off-by: Eric Dumazet <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_object.c')
0 files changed, 0 insertions, 0 deletions
