aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
diff options
context:
space:
mode:
authorSmita Koralahalli <[email protected]>2025-04-07 19:27:34 +0000
committerDave Jiang <[email protected]>2025-04-21 15:30:13 +0000
commit078d3ee7c162cd66d76171579c02d7890bd77daf (patch)
tree2b3c29b7fd1d7704e464b1ec251104ae592ea9ae /drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
parentcxl/feature: Update out_len in set feature failure case (diff)
downloadkernel-078d3ee7c162cd66d76171579c02d7890bd77daf.tar.gz
kernel-078d3ee7c162cd66d76171579c02d7890bd77daf.zip
cxl/core/regs.c: Skip Memory Space Enable check for RCD and RCH Ports
According to CXL r3.2 section 8.2.1.2, the PCI_COMMAND register fields, including Memory Space Enable bit, have no effect on the behavior of an RCD Upstream Port. Retaining this check may incorrectly cause cxl_pci_probe() to fail on a valid RCD upstream Port. While the specification is explicit only for RCD Upstream Ports, this check is solely for accessing the RCRB, which is always mapped through memory space. Therefore, its safe to remove the check entirely. In practice, firmware reliably enables the Memory Space Enable bit for RCH Downstream Ports and no failures have been observed. Removing the check simplifies the code and avoids unnecessary special-casing, while relying on BIOS/firmware to configure devices correctly. Moreover, any failures due to inaccessible RCRB regions will still be caught either in __rcrb_to_component() or while parsing the component register block. The following failure was observed in dmesg when the check was present: cxl_pci 0000:7f:00.0: No component registers (-6) Fixes: d5b1a27143cb ("cxl/acpi: Extract component registers of restricted hosts from RCRB") Signed-off-by: Smita Koralahalli <[email protected]> Cc: <[email protected]> Reviewed-by: Ira Weiny <[email protected]> Reviewed-by: Terry Bowman <[email protected]> Reviewed-by: Dave Jiang <[email protected]> Reviewed-by: Robert Richter <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Dave Jiang <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_object.c')
0 files changed, 0 insertions, 0 deletions