diff options
| author | Jeffrey Hugo <[email protected]> | 2025-02-14 16:21:09 +0000 |
|---|---|---|
| committer | Jeff Hugo <[email protected]> | 2025-02-21 17:29:28 +0000 |
| commit | acf3256160bdabcb5c07032f3bf6eb5a21f5b95f (patch) | |
| tree | f193f8f6fedd72c4b31c855a7c5027bbcb5f33ea /drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | |
| parent | MAINTAINERS: Update my email address (diff) | |
| download | kernel-acf3256160bdabcb5c07032f3bf6eb5a21f5b95f.tar.gz kernel-acf3256160bdabcb5c07032f3bf6eb5a21f5b95f.zip | |
bus: mhi: host: Avoid possible uninitialized fw_load_type
If mhi_fw_load_handler() bails out early because the EE is not capable
of loading firmware, we may reference fw_load_type in cleanup which is
uninitialized at this point. The cleanup code checks fw_load_type as a
proxy for knowing if fbc_image was allocated and needs to be freed, but
we can directly test for that. This avoids the possible uninitialized
access and appears to be clearer code.
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Fixes: f88f1d0998ea ("bus: mhi: host: Add a policy to enable image transfer via BHIe in PBL")
Signed-off-by: Jeffrey Hugo <[email protected]>
Acked-by: Manivannan Sadhasivam <[email protected]>
Reviewed-by: Carl Vanderlip <[email protected]>
Signed-off-by: Jeff Hugo <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_job.c')
0 files changed, 0 insertions, 0 deletions