diff options
| author | Nam Cao <[email protected]> | 2025-07-24 17:33:28 +0000 |
|---|---|---|
| committer | Steven Rostedt (Google) <[email protected]> | 2025-07-25 13:04:14 +0000 |
| commit | 3d3c376118b5f7ed7723c2b4fd7a0a1c1893d63e (patch) | |
| tree | 56debfedf1ec7b0ccec5eff43b67416dd8324291 /drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | |
| parent | rv: Merge struct rv_monitor_def into struct rv_monitor (diff) | |
| download | kernel-3d3c376118b5f7ed7723c2b4fd7a0a1c1893d63e.tar.gz kernel-3d3c376118b5f7ed7723c2b4fd7a0a1c1893d63e.zip | |
rv: Merge struct rv_reactor_def into struct rv_reactor
Each struct rv_reactor has a unique struct rv_reactor_def associated with
it. struct rv_reactor is statically allocated, while struct rv_reactor_def
is dynamically allocated.
This makes the code more complicated than it should be:
- Lookup is required to get the associated rv_reactor_def from rv_reactor
- Dynamic memory allocation is required for rv_reactor_def. This is
harder to get right compared to static memory. For instance, there is
an existing mistake: rv_unregister_reactor() does not free the memory
allocated by rv_register_reactor(). This is fortunately not a real
memory leak problem as rv_unregister_reactor() is never called.
Simplify and merge rv_reactor_def into rv_reactor.
Cc: Masami Hiramatsu <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
Link: https://lore.kernel.org/71cb91c86cd40df5b8c492b788787f2a73c3eaa3.1753378331.git.namcao@linutronix.de
Reviewed-by: Gabriele Monaco <[email protected]>
Signed-off-by: Nam Cao <[email protected]>
Signed-off-by: Steven Rostedt (Google) <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c')
0 files changed, 0 insertions, 0 deletions
