aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
diff options
context:
space:
mode:
authorDave Hansen <[email protected]>2025-06-24 21:01:48 +0000
committerDave Hansen <[email protected]>2025-06-25 23:28:06 +0000
commit1cec9ac2d071cfd2da562241aab0ef701355762a (patch)
treeef956d0af8d304f0dedf3a106152da08011752fb /drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
parentx86/fpu/xstate: Add CET supervisor xfeature support as a guest-only feature (diff)
downloadkernel-1cec9ac2d071cfd2da562241aab0ef701355762a.tar.gz
kernel-1cec9ac2d071cfd2da562241aab0ef701355762a.zip
x86/fpu: Delay instruction pointer fixup until after warning
Right now, if XRSTOR fails a console message like this is be printed: Bad FPU state detected at restore_fpregs_from_fpstate+0x9a/0x170, reinitializing FPU registers. However, the text location (...+0x9a in this case) is the instruction *AFTER* the XRSTOR. The highlighted instruction in the "Code:" dump also points one instruction late. The reason is that the "fixup" moves RIP up to pass the bad XRSTOR and keep on running after returning from the #GP handler. But it does this fixup before warning. The resulting warning output is nonsensical because it looks like the non-FPU-related instruction is #GP'ing. Do not fix up RIP until after printing the warning. Do this by using the more generic and standard ex_handler_default(). Fixes: d5c8028b4788 ("x86/fpu: Reinitialize FPU registers if restoring FPU state fails") Signed-off-by: Dave Hansen <[email protected]> Reviewed-by: Chao Gao <[email protected]> Acked-by: Alison Schofield <[email protected]> Acked-by: Peter Zijlstra (Intel) <[email protected]> Cc:[email protected] Link: https://lore.kernel.org/all/20250624210148.97126F9E%40davehans-spike.ostc.intel.com
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c')
0 files changed, 0 insertions, 0 deletions