diff options
| author | Jarkko Sakkinen <[email protected]> | 2024-05-13 18:19:04 +0000 |
|---|---|---|
| committer | Jarkko Sakkinen <[email protected]> | 2024-05-20 23:35:10 +0000 |
| commit | 050bf3c793a07f96bd1e2fd62e1447f731ed733b (patch) | |
| tree | 0d4f3a065e62e35213a5e257ec10d1f656a7bb78 /drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | |
| parent | KEYS: trusted: Fix memory leak in tpm2_key_encode() (diff) | |
| download | kernel-050bf3c793a07f96bd1e2fd62e1447f731ed733b.tar.gz kernel-050bf3c793a07f96bd1e2fd62e1447f731ed733b.zip | |
KEYS: trusted: Do not use WARN when encode fails
When asn1_encode_sequence() fails, WARN is not the correct solution.
1. asn1_encode_sequence() is not an internal function (located
in lib/asn1_encode.c).
2. Location is known, which makes the stack trace useless.
3. Results a crash if panic_on_warn is set.
It is also noteworthy that the use of WARN is undocumented, and it
should be avoided unless there is a carefully considered rationale to
use it.
Replace WARN with pr_err, and print the return value instead, which is
only useful piece of information.
Cc: [email protected] # v5.13+
Fixes: f2219745250f ("security: keys: trusted: use ASN.1 TPM2 key format for the blobs")
Signed-off-by: Jarkko Sakkinen <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c')
0 files changed, 0 insertions, 0 deletions