diff options
| author | Simon Ser <[email protected]> | 2021-01-10 12:51:03 +0000 |
|---|---|---|
| committer | Simon Ser <[email protected]> | 2021-01-12 14:52:43 +0000 |
| commit | cc3283f8f41f741fbaef63d0503d8fb4a7919100 (patch) | |
| tree | 41a78de8ef893266d80d58b555f546b5b03f4362 /drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | |
| parent | drm: distinguish return value of drm_dp_check_and_send_link_address (diff) | |
| download | kernel-cc3283f8f41f741fbaef63d0503d8fb4a7919100.tar.gz kernel-cc3283f8f41f741fbaef63d0503d8fb4a7919100.zip | |
drm/fourcc: fix Amlogic format modifier masks
The comment says the layout and options use 8 bits, and the shift
uses 8 bits. However the mask is 0xf, ie. 0b00001111 (4 bits).
This could be surprising when introducing new layouts or options
that take more than 4 bits, as this would silently drop the high
bits.
Make the masks consistent with the comment and the shift.
Found when writing a drm_info patch [1].
[1]: https://github.com/ascent12/drm_info/pull/67
Signed-off-by: Simon Ser <[email protected]>
Fixes: d6528ec88309 ("drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression")
Cc: Neil Armstrong <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Kevin Hilman <[email protected]>
Cc: Daniel Vetter <[email protected]>
Acked-by: Neil Armstrong <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c')
0 files changed, 0 insertions, 0 deletions