diff options
| author | Peter Geis <[email protected]> | 2025-02-20 18:58:08 +0000 |
|---|---|---|
| committer | Ulf Hansson <[email protected]> | 2025-02-28 12:07:04 +0000 |
| commit | 6b2690df3f032d91546841dcca44d5acdb7ace1e (patch) | |
| tree | f86fbd1890cc7925412a493c9715df0b6fe65a76 /drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | |
| parent | pmdomain: rockchip: reduce indentation in rockchip_pd_power (diff) | |
| download | kernel-6b2690df3f032d91546841dcca44d5acdb7ace1e.tar.gz kernel-6b2690df3f032d91546841dcca44d5acdb7ace1e.zip | |
pmdomain: rockchip: fix rockchip_pd_power error handling
The calls rockchip_pd_power makes to rockchip_pmu_set_idle_request lack
any return error handling, causing device drivers to incorrectly believe
the hardware idle requests succeed when they may have failed. This leads
to software possibly accessing hardware that is powered off and the
subsequent SError panic that follows.
Add error checking and return errors to the calling function to prevent
such crashes.
gst-launch-1.0 videotestsrc num-buffers=2000 ! v4l2jpegenc ! fakesink
Setting pipeline to PAUSED ...er-x64
Pipeline is PREROLLING ...
Redistribute latency...
rockchip-pm-domain ff100000.syscon:power-controller: failed to get ack on domain 'hevc', val=0x98260
SError Interrupt on CPU2, code 0x00000000bf000002 -- SError
Signed-off-by: Peter Geis <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Sebastian Reichel <[email protected]>
Link: https://lore.kernel.org/r/20250220-rk3588-gpu-pwr-domain-regulator-v6-5-a4f9c24e5b81@kernel.org
Signed-off-by: Ulf Hansson <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c')
0 files changed, 0 insertions, 0 deletions