diff options
| author | Zhipeng Lu <[email protected]> | 2023-12-14 16:59:38 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2023-12-14 20:29:08 +0000 |
| commit | a6582701178a47c4d0cb2188c965c59c0c0647c8 (patch) | |
| tree | 653ce21587976770a0358ca7416f68fc32de2c4d /drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | |
| parent | gpu/drm/radeon: fix two memleaks in radeon_vm_init (diff) | |
| download | kernel-a6582701178a47c4d0cb2188c965c59c0c0647c8.tar.gz kernel-a6582701178a47c4d0cb2188c965c59c0c0647c8.zip | |
drm/amd/pm: fix a double-free in amdgpu_parse_extended_power_table
The amdgpu_free_extended_power_table is called in every error-handling
paths of amdgpu_parse_extended_power_table. However, after the following
call chain of returning:
amdgpu_parse_extended_power_table
|-> kv_dpm_init / si_dpm_init
(the only two caller of amdgpu_parse_extended_power_table)
|-> kv_dpm_sw_init / si_dpm_sw_init
(the only caller of kv_dpm_init / si_dpm_init, accordingly)
|-> kv_dpm_fini / si_dpm_fini
(goto dpm_failed in xx_dpm_sw_init)
|-> amdgpu_free_extended_power_table
As above, the amdgpu_free_extended_power_table is called twice in this
returning chain and thus a double-free is triggered. Similarily, the
last kfree in amdgpu_parse_extended_power_table also cause a double free
with amdgpu_free_extended_power_table in kv_dpm_fini.
Fixes: 84176663e70d ("drm/amd/pm: create a new holder for those APIs used only by legacy ASICs(si/kv)")
Signed-off-by: Zhipeng Lu <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c')
0 files changed, 0 insertions, 0 deletions
