diff options
| author | Emil Velikov <[email protected]> | 2020-03-19 17:29:29 +0000 |
|---|---|---|
| committer | Emil Velikov <[email protected]> | 2020-03-30 11:20:32 +0000 |
| commit | 45bc3d26c95a8fc63a7d8668ca9e57ef0883351c (patch) | |
| tree | 2b8b7a32df9762d6a9025fd4ab6d9d6f7c920358 /drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | |
| parent | drm/radeon: convert to use i2c_new_client_device() (diff) | |
| download | kernel-45bc3d26c95a8fc63a7d8668ca9e57ef0883351c.tar.gz kernel-45bc3d26c95a8fc63a7d8668ca9e57ef0883351c.zip | |
drm: rework SET_MASTER and DROP_MASTER perm handling
This commit reworks the permission handling of the two ioctls. In
particular it enforced the CAP_SYS_ADMIN check only, if:
- we're issuing the ioctl from process other than the one which opened
the node, and
- we are, or were master in the past
This ensures that we:
- do not regress the systemd-logind style of DRM_MASTER arbitrator
- allow applications which do not use systemd-logind to drop their
master capabilities (and regain them at later point) ... w/o running as
root.
See the comment above drm_master_check_perm() for more details.
v1:
- Tweak wording, fixup all checks, add igt test
v2:
- Add a few more comments, grammar nitpicks.
Cc: Adam Jackson <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Pekka Paalanen <[email protected]>
Testcase: igt/core_setmaster/master-drop-set-user
Signed-off-by: Emil Velikov <[email protected]>
Reviewed-by: Adam Jackson <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c')
0 files changed, 0 insertions, 0 deletions