diff options
| author | Ondrej Jirman <[email protected]> | 2018-03-10 11:05:11 +0000 |
|---|---|---|
| committer | Maxime Ripard <[email protected]> | 2018-03-12 09:07:17 +0000 |
| commit | 7035046d6d02d455325c5d0328bcc8a0b5dd96b0 (patch) | |
| tree | 636eb6ac5d2643b3a16c1856832791cc1e76599b /drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | |
| parent | Merge branch 'drm-fixes-4.16' of git://people.freedesktop.org/~agd5f/linux in... (diff) | |
| download | kernel-7035046d6d02d455325c5d0328bcc8a0b5dd96b0.tar.gz kernel-7035046d6d02d455325c5d0328bcc8a0b5dd96b0.zip | |
drm/sun4i: Fix exclusivity of the TCON clocks
Currently the exclusivity is enabled when the rate is set by
the mode setting functions. These functions are called by
mode_set_nofb callback of drm_crc_helper. Then exclusivity
is disabled when tcon is disabled by atomic_disable
callback.
What happens is that mode_set_nofb can be called once when
mode changes, and afterwards the system can call atomic_enable
and atomic_disable multiple times without further calls to
mode_set_nofb.
This happens:
mode_set_nofb - clk exclusivity is enabled
atomic_enable
atomic_disable - clk exclusivity is disabled
atomic_enable
atomic_disable - clk exclusivity is already disabled, leading to WARN
in clk_rate_exclusive_put
Solution is to enable exclusivity in sun4i_tcon_channel_set_status.
Signed-off-by: Ondrej Jirman <[email protected]>
Cc: Jernej Skrabec <[email protected]>
Signed-off-by: Maxime Ripard <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_device.c')
0 files changed, 0 insertions, 0 deletions