diff options
| author | Thomas Zimmermann <[email protected]> | 2025-07-15 15:58:16 +0000 |
|---|---|---|
| committer | Thomas Zimmermann <[email protected]> | 2025-07-17 10:26:19 +0000 |
| commit | 6d496e9569983a0d7a05be6661126d0702cf94f7 (patch) | |
| tree | 22932683ea0f3cea933ed3f85c329c7d8e676cd1 /drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | |
| parent | Revert "drm/gem-framebuffer: Use dma_buf from GEM object instance" (diff) | |
| download | kernel-6d496e9569983a0d7a05be6661126d0702cf94f7.tar.gz kernel-6d496e9569983a0d7a05be6661126d0702cf94f7.zip | |
Revert "drm/gem-shmem: Use dma_buf from GEM object instance"
This reverts commit 1a148af06000e545e714fe3210af3d77ff903c11.
The dma_buf field in struct drm_gem_object is not stable over the
object instance's lifetime. The field becomes NULL when user space
releases the final GEM handle on the buffer object. This resulted
in a NULL-pointer deref.
Workarounds in commit 5307dce878d4 ("drm/gem: Acquire references on
GEM handles for framebuffers") and commit f6bfc9afc751 ("drm/framebuffer:
Acquire internal references on GEM handles") only solved the problem
partially. They especially don't work for buffer objects without a DRM
framebuffer associated.
Hence, this revert to going back to using .import_attach->dmabuf.
v3:
- cc stable
Signed-off-by: Thomas Zimmermann <[email protected]>
Reviewed-by: Simona Vetter <[email protected]>
Acked-by: Christian König <[email protected]>
Acked-by: Zack Rusin <[email protected]>
Cc: <[email protected]> # v6.15+
Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_device.c')
0 files changed, 0 insertions, 0 deletions