aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
diff options
context:
space:
mode:
authorArnd Bergmann <[email protected]>2025-07-22 11:58:18 +0000
committerDanilo Krummrich <[email protected]>2025-07-22 12:03:27 +0000
commit270b329f7ec4e4e8dca6735bd1fe286a8e39b82d (patch)
tree888887f80df3b9cb36130cfe9262be7443bedf92 /drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
parentdrm/nouveau/nvif: fix null ptr deref on pre-fermi boards (diff)
downloadkernel-270b329f7ec4e4e8dca6735bd1fe286a8e39b82d.tar.gz
kernel-270b329f7ec4e4e8dca6735bd1fe286a8e39b82d.zip
Revert "drm/nouveau: check ioctl command codes better"
My previous patch ended up causing a regression for the DRM_IOCTL_NOUVEAU_NVIF ioctl. The intention of my patch was to only pass ioctl commands that have the correct dir/type/nr bits into the nouveau_abi16_ioctl() function. This turned out to be too strict, as userspace does use at least write-only and write-read direction settings. Checking for both of these still did not fix the issue, so the best we can do for the 6.16 release is to revert back to what we've had since linux-3.16. This version is still fragile, but at least it is known to work with existing userspace. Fixing this properly requires a better understanding of what commands are being passed from userspace in practice, and how that relies on the undocumented (miss)behavior in nouveau_drm_ioctl(). Fixes: e5478166dffb ("drm/nouveau: check ioctl command codes better") Reported-by: Satadru Pramanik <[email protected]> Closes: https://lore.kernel.org/lkml/CAFrh3J85tsZRpOHQtKgNHUVnn=EG=QKBnZTRtWS8eWSc1K1xkA@mail.gmail.com/ Reported-by: Chris Bainbridge <[email protected]> Closes: https://lore.kernel.org/lkml/[email protected]/ Signed-off-by: Arnd Bergmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] [ Add Closes: tags, fix minor typo in commit message. - Danilo ] Signed-off-by: Danilo Krummrich <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_device.c')
0 files changed, 0 insertions, 0 deletions