diff options
| author | Sven Schnelle <[email protected]> | 2022-07-06 10:16:25 +0000 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2022-07-09 18:06:19 +0000 |
| commit | de2a34771f5123270bc3842535ac91673116dd03 (patch) | |
| tree | 755f78fff73e916a30fb98a0fafe7b88f68c637c /drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | |
| parent | Merge tag 'powerpc-5.19-5' of git://git.kernel.org/pub/scm/linux/kernel/git/p... (diff) | |
| download | kernel-de2a34771f5123270bc3842535ac91673116dd03.tar.gz kernel-de2a34771f5123270bc3842535ac91673116dd03.zip | |
ptrace: fix clearing of JOBCTL_TRACED in ptrace_unfreeze_traced()
CI reported the following splat while running the strace testsuite:
WARNING: CPU: 1 PID: 3570031 at kernel/ptrace.c:272 ptrace_check_attach+0x12e/0x178
CPU: 1 PID: 3570031 Comm: strace Tainted: G OE 5.19.0-20220624.rc3.git0.ee819a77d4e7.300.fc36.s390x #1
Hardware name: IBM 3906 M04 704 (z/VM 7.1.0)
Call Trace:
[<00000000ab4b645a>] ptrace_check_attach+0x132/0x178
([<00000000ab4b6450>] ptrace_check_attach+0x128/0x178)
[<00000000ab4b6cde>] __s390x_sys_ptrace+0x86/0x160
[<00000000ac03fcec>] __do_syscall+0x1d4/0x200
[<00000000ac04e312>] system_call+0x82/0xb0
Last Breaking-Event-Address:
[<00000000ab4ea3c8>] wait_task_inactive+0x98/0x190
This is because JOBCTL_TRACED is set, but the task is not in TASK_TRACED
state. Caused by ptrace_unfreeze_traced() which does:
task->jobctl &= ~TASK_TRACED
but it should be:
task->jobctl &= ~JOBCTL_TRACED
Fixes: 31cae1eaae4f ("sched,signal,ptrace: Rework TASK_TRACED, TASK_STOPPED state")
Signed-off-by: Sven Schnelle <[email protected]>
Tested-by: Alexander Gordeev <[email protected]>
Acked-by: Oleg Nesterov <[email protected]>
Acked-by: Peter Zijlstra <[email protected]>
Cc: Eric Biederman <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Kees Cook <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c')
0 files changed, 0 insertions, 0 deletions