diff options
| author | Sudeep Holla <[email protected]> | 2025-03-14 09:58:51 +0000 |
|---|---|---|
| committer | Ulf Hansson <[email protected]> | 2025-03-17 10:12:01 +0000 |
| commit | 6cf5db71dc6d51ede4ff77cab126876ecf065048 (patch) | |
| tree | 0be6a7adaa0ed9544104e996705160863767477a /drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | |
| parent | pmdomain: thead: fix TH1520_AON_PROTOCOL dependency (diff) | |
| download | kernel-6cf5db71dc6d51ede4ff77cab126876ecf065048.tar.gz kernel-6cf5db71dc6d51ede4ff77cab126876ecf065048.zip | |
pmdomain: arm: scmi_pm_domain: Remove redundant state verification
Currently, scmi_pd_power() explicitly verifies whether the requested
power state was applied by calling state_get(). While this check could
detect failures where the state was not properly updated, ensuring
correctness is the responsibility of the SCMI firmware.
Removing this redundant state_get() call eliminates an unnecessary
round-trip to the firmware, improving efficiency. Any mismatches
between the requested and actual states should be handled by the SCMI
firmware, which must return a failure if state_set() is unsuccessful.
Additionally, in some cases, checking the state after powering off a
domain may be unreliable or unsafe, depending on the firmware
implementation.
This patch removes the redundant verification, simplifying the function
without compromising correctness.
Reported-and-tested-by: Ranjani Vaidyanathan <[email protected]>
Signed-off-by: Sudeep Holla <[email protected]>
Reviewed-by: Peng Fan <[email protected]>
Reviewed-by: Cristian Marussi <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Ulf Hansson <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c')
0 files changed, 0 insertions, 0 deletions
