diff options
| author | Len Baker <[email protected]> | 2021-09-04 15:41:06 +0000 |
|---|---|---|
| committer | Alex Deucher <[email protected]> | 2021-09-07 17:30:50 +0000 |
| commit | 67684fcbdd0ef60a52f15e74e0e8a85edc867ce4 (patch) | |
| tree | 532110bcbcffff43b4f54ca44b74bda49b14c7ca /drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | |
| parent | drm/amdgpu: sdma: clean up identation (diff) | |
| download | kernel-67684fcbdd0ef60a52f15e74e0e8a85edc867ce4.tar.gz kernel-67684fcbdd0ef60a52f15e74e0e8a85edc867ce4.zip | |
drm/radeon: Prefer kcalloc over open coded arithmetic
As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.
So, refactor the code a bit to use the purpose specific kcalloc()
function instead of the calculated size argument in the kzalloc()
function.
[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Signed-off-by: Len Baker <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c')
0 files changed, 0 insertions, 0 deletions
