aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
diff options
context:
space:
mode:
authorJeongjun Park <[email protected]>2025-01-10 16:26:12 +0000
committerSteven Rostedt (Google) <[email protected]>2025-01-13 21:05:43 +0000
commit6e31b759b076eebb4184117234f0c4eb9e4bc460 (patch)
tree119350c2e312ed1b0c42974390d61a02af9db3de /drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
parentring-buffer: Check for empty ring-buffer with rb_num_of_entries() (diff)
downloadkernel-6e31b759b076eebb4184117234f0c4eb9e4bc460.tar.gz
kernel-6e31b759b076eebb4184117234f0c4eb9e4bc460.zip
ring-buffer: Make reading page consistent with the code logic
In the loop of __rb_map_vma(), the 's' variable is calculated from the same logic that nr_pages is and they both come from nr_subbufs. But the relationship is not obvious and there's a WARN_ON_ONCE() around the 's' variable to make sure it never becomes equal to nr_subbufs within the loop. If that happens, then the code is buggy and needs to be fixed. The 'page' variable is calculated from cpu_buffer->subbuf_ids[s] which is an array of 'nr_subbufs' entries. If the code becomes buggy and 's' becomes equal to or greater than 'nr_subbufs' then this will be an out of bounds hit before the WARN_ON() is triggered and the code exiting safely. Make the 'page' initialization consistent with the code logic and assign it after the out of bounds check. Link: https://lore.kernel.org/[email protected] Signed-off-by: Jeongjun Park <[email protected]> [ sdr: rewrote change log ] Signed-off-by: Steven Rostedt (Google) <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c')
0 files changed, 0 insertions, 0 deletions